Skip to content

Remove unused parameter#33

Open
RSpeekenbrink wants to merge 2 commits intothephpleague:masterfrom
RSpeekenbrink:remove-unused-parameter
Open

Remove unused parameter#33
RSpeekenbrink wants to merge 2 commits intothephpleague:masterfrom
RSpeekenbrink:remove-unused-parameter

Conversation

@RSpeekenbrink
Copy link

@RSpeekenbrink RSpeekenbrink commented Jan 6, 2020 •
edited
Loading

Remove unused amount parameter in CompletePurchaseRequest. Validation on this parameter means you have to access your order before you can actually access the PaymentId trough a gateway meaning you have to add custom logic for buckaroo payments. IE:

$order = Order::find($request->get('BQ_INVOICENUMBER'));
$response = Omnipay::CompletePurchase(array_merge(
    [ 'amount' => $order->amount ],
    request()->all(),
))->send();

With this fix this is no longer required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@RSpeekenbrink